Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch proxies to LazyGhostTrait #2700

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Switch proxies to LazyGhostTrait #2700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d297a49
Generate proxy classes using symfony/var-exporter
GromNaN Nov 23, 2024
6b404b5
Leverage UOW::initializeObject in tests
GromNaN Nov 23, 2024
e528f8c
Trigger lifecycleEventManager from lazy ghost object
GromNaN Nov 23, 2024
4e34386
Run the full test suite with proxy manager
GromNaN Nov 23, 2024
041b12f
Fix assert not lazy object
GromNaN Nov 23, 2024
1888aab
Fix deprecation version and refactor autoregenerate condition
GromNaN Dec 31, 2024
564f32d
Fix testCreateProxyForDocumentWithUnmappedProperties
GromNaN Dec 31, 2024
1ce91ac
Keep a single ProxyManagerConfiguration instance
GromNaN Jan 21, 2025
4d4c864
Type fixes
GromNaN Jan 21, 2025
3820d20
Merge branch '2.10.x' into proxy-var-exporter-2
IonBazan Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Type fixes
  • Loading branch information
@GromNaN
GromNaN committed Jan 21, 2025
commit 4d4c8647320641ea4c343ac14dfa7efdcb4cefb5
3 changes: 1 addition & 2 deletions lib/Doctrine/ODM/MongoDB/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ class Configuration

private bool $useLazyGhostObject = true;


/**
* Adds a namespace under a certain alias.
*/
Expand Down Expand Up @@ -652,7 +651,7 @@ public function setUseLazyGhostObject(bool $flag): void

public function isLazyGhostObjectEnabled(): bool
{
return $this->useLazyGhostObject ?? true;
return $this->useLazyGhostObject;
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/ODM/MongoDB/Proxy/Factory/LazyGhostProxyFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function __construct(
$this->lifecycleEventManager = new LifecycleEventManager($dm, $this->uow, $dm->getEventManager());
}

/** @param array<mixed> $identifier */
/** @param mixed $identifier */
public function getProxy(ClassMetadata $metadata, $identifier): InternalProxy
{
$className = $metadata->getName();
Expand Down