Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate keys in data providers #2629

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Apr 24, 2024

Fixes #2624

The $isArray and $objectArray are already tested through the type and object data providers, so they don't need to appear in the array provider.

Also fixes a wrong indentation level in another data provider.

@alcaeus alcaeus self-assigned this Apr 24, 2024
@alcaeus alcaeus linked an issue Apr 24, 2024 that may be closed by this pull request
@alcaeus alcaeus requested a review from jmikola April 24, 2024 07:40
@alcaeus alcaeus merged commit 89da7c8 into doctrine:2.7.x Apr 24, 2024
20 checks passed
@alcaeus alcaeus deleted the fix-duplicate-dataset branch April 24, 2024 13:49
@alcaeus alcaeus added this to the 2.7.1 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate objectToArray keys in AggregationOperatorsProviderTrait
2 participants