Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not drop/re-create 2dsphere indexes #2575

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

buffcode
Copy link
Contributor

@buffcode buffcode commented Nov 6, 2023

Q A
Type bug
BC Break no
Fixed issues Fixes #2574

Summary

Indexes of tpye 2dsphere are always re-created, because the server-side options contain a 2dsphereIndexVersion, which causes a mismatch when comparing index options.

@alcaeus alcaeus changed the base branch from 2.6.x to 2.5.x November 6, 2023 07:41
@alcaeus alcaeus self-assigned this Nov 6, 2023
@alcaeus alcaeus added the Bug label Nov 6, 2023
@alcaeus alcaeus added this to the 2.5.5 milestone Nov 6, 2023
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing! 🎉

@alcaeus alcaeus linked an issue Nov 6, 2023 that may be closed by this pull request
@alcaeus alcaeus merged commit d6f1686 into doctrine:2.5.x Nov 6, 2023
alcaeus added a commit that referenced this pull request Nov 24, 2023
* fix: Do not drop/re-create 2dsphere indexes (#2575)

* Validate that targetDocument can be resolved (#2577)

* fix: Validate that targetDocument can be resolved

* refactor: Use exception factory

* fix: Validate that all values in a discriminatorMap can be resolved

* fix: PHPStan errors for intentionally missing class

* fix: psalm/phpunit CI tests

---------

Co-authored-by: buffcode <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2dsphere indexes get re-created everytime
2 participants