Normalize assert calls in tests #2477
Conversation
hunomina
force-pushed
the
normalize-assert-calls-in-tests-2
branch
2 times, most recently
from
3104344 to
2062a66
Compare
.idea/.gitignore
Outdated
| @@ -0,0 +1,8 @@ | |||
| # Default ignored files | |||
There was a problem hiding this comment.
Can you please remove the .idea files from the PR? Usually it's best to keep IDE-specific files excluded from git via a global .gitignore file
There was a problem hiding this comment.
Oh yeah absolutely, my last (forced) push didn't go through apparently 😅
I'll fix that 😉
I'll add the idea directory to the .gitignore in a separate commit 😉
There was a problem hiding this comment.
Deal is that we don't want to keep IDE-specific files in project's .gitignore either :)
There was a problem hiding this comment.
Oh ok, not even in the .gitignore 😮 ?
That's weird but ok whatever 😉
I removed my last commit, the one changing the .gitignore 😉
There was a problem hiding this comment.
Yeah, not even in .gitignore. Reasoning is simple: we don't want to have each and every contributor's IDE-specific files listed there 😅 While a lot of folks use JetBrains' IDEs, it's not always the case. The global .gitignore is a file you point your local git to and it adds up to whatever .gitignore is found in projects. Really handy :)
Some unusual calls were forgotten in the preview PR
hunomina
force-pushed
the
normalize-assert-calls-in-tests-2
branch
2 times, most recently
from
11e2be9 to
7a821c2
Compare
|
Thanks @hunomina! |
Some unusual calls were forgotten in the preview PR
Summary
Normalizes assert*() calls in tests