Add warning about potential signature incompatibility #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
Oct 2, 2022
UPGRADE-2.5.md
Outdated
| To comply with the new interface of `Collection` introduced in 2.0.0, | ||
| `findFirst()` and `reduce()` have been added to `PersistentCollectionTrait`. | ||
| Make sure to remove your own implementations of these methods if you have any | ||
| and are using that trait. |
There was a problem hiding this comment.
Trait is used by ODM itself. New methods can collide with custom collection and signatures in them :)
greg0ire
force-pushed
the
warn-about-signature-incompatibility
branch
from
5f175f8 to
304d777
Compare
malarzm
approved these changes
Oct 2, 2022
|
Thanks @greg0ire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.