Deprecate NOTIFY tracking policy #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
force-pushed
the
deprecate-notify-tracking-policy
branch
2 times, most recently
from
f2d8c19 to
86eb899
Compare
franmomu
reviewed
Apr 30, 2022
| @@ -207,6 +208,15 @@ protected function doLoadMetadata($class, $parent, $rootEntityFound, array $nonS | |||
|
|
|||
| $eventArgs = new LoadClassMetadataEventArgs($class, $this->dm); | |||
| $this->evm->dispatchEvent(Events::loadClassMetadata, $eventArgs); | |||
|
|
|||
| if ($class->isChangeTrackingNotify()) { | |||
There was a problem hiding this comment.
the CS build wants to invert the condition to use early exit, but in this case the code is more readable the way it is
There was a problem hiding this comment.
I've decided to ignore the error. Offending lines will be gone eventually and so will be the suppression. Is this OK?
malarzm
force-pushed
the
deprecate-notify-tracking-policy
branch
from
86eb899 to
6fd90ed
Compare
franmomu
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2424