Fix PHPStan issues #2407
Merged
Fix PHPStan issues #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
fix_sa_issues
branch
from
0305cf8 to
2abd78c
Compare
malarzm
reviewed
Feb 14, 2022
| @@ -37,10 +37,10 @@ class GraphLookup extends Stage | |||
| /** @var string */ | |||
| private $as; | |||
|
|
|||
| /** @var int */ | |||
| /** @var int|null */ | |||
There was a problem hiding this comment.
at a glance fields above should get |null as well, no?
There was a problem hiding this comment.
yep, I have to try to keep increasing static analysis level when I find some time
franmomu
force-pushed
the
fix_sa_issues
branch
from
2abd78c to
0c38e97
Compare
franmomu
force-pushed
the
fix_sa_issues
branch
from
0c38e97 to
c3486da
Compare
SenseException
approved these changes
Feb 14, 2022
malarzm
approved these changes
Feb 15, 2022
|
Thanks @franmomu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's nice to see some ignored errors go :)