Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 types in custom collections #2398

Merged
merged 2 commits into from
Dec 25, 2021
Merged

PHP 8.1 types in custom collections #2398

merged 2 commits into from
Dec 25, 2021

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Dec 21, 2021

Q A
Type bug
BC Break no
Fixed issues fixes #2397

@malarzm malarzm marked this pull request as draft December 21, 2021 19:27
@malarzm malarzm changed the title Intersection types in custom collections PHP 8.1 types in custom collections Dec 21, 2021
@malarzm malarzm force-pushed the php-8-1 branch 3 times, most recently from 33f532c to e6e744e Compare December 21, 2021 19:51
@malarzm malarzm force-pushed the php-8-1 branch 3 times, most recently from f7b3f7d to 22c8346 Compare December 21, 2021 21:14
@malarzm malarzm marked this pull request as ready for review December 21, 2021 21:19
Copy link
Contributor

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@malarzm malarzm added the Bug label Dec 25, 2021
@malarzm malarzm added this to the 2.3.1 milestone Dec 25, 2021
@malarzm malarzm merged commit 47642e7 into doctrine:2.3.x Dec 25, 2021
@malarzm malarzm deleted the php-8-1 branch December 25, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle intersection types in custom collections
2 participants