Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type hints to tests #2366

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add return type hints to tests #2366

merged 1 commit into from
Sep 14, 2021

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Sep 3, 2021

Q A
Type improvement
BC Break no
Fixed issues

Summary

Needs #2365

In the quest of having more type hints in the code, this PR adds return types to tests directory.

@franmomu franmomu added the Task label Sep 3, 2021
@franmomu franmomu requested a review from malarzm September 13, 2021 22:40
@malarzm malarzm added this to the 2.3.0 milestone Sep 14, 2021
@malarzm malarzm merged commit 38fc494 into doctrine:2.3.x Sep 14, 2021
@malarzm
Copy link
Member

malarzm commented Sep 14, 2021

Thanks @franmomu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malarzm malarzm malarzm approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @malarzm