Fix some issues of Psalm in level 6 #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
issues_tests_sa
branch
from
e58e089 to
60eaa3b
Compare
franmomu
commented
Jun 21, 2021
| $bucket->getFilesCollection() | ||
| ->expects($this->any()) | ||
| $filesCollection = $bucket->getFilesCollection(); | ||
| assert($filesCollection instanceof Collection && $filesCollection instanceof MockObject); |
There was a problem hiding this comment.
here, $bucket is a mock and getFilesCollection returns also a mock, not sure how that can be expressed other than this or we can just ignore it.
franmomu
force-pushed
the
issues_tests_sa
branch
from
fadd532 to
08bdcdf
Compare
malarzm
reviewed
Jun 21, 2021
| @@ -129,7 +129,10 @@ public function testClosureToPHP($input, $output) | |||
| return $return; | |||
| })($input); | |||
|
|
|||
| $this->assertInstanceOf('DateTimeImmutable', $return); | |||
| // @phpstan-ignore-next-line | |||
There was a problem hiding this comment.
Why do we need to ignore assert below?
There was a problem hiding this comment.
Because of the eval in the closure, phpstan says:
------ ------------------------------------------------------------------------------
Line tests/Doctrine/ODM/MongoDB/Tests/Types/DateImmutableTypeTest.php
------ ------------------------------------------------------------------------------
131 Call to function assert() with false will always evaluate to false.
131 Instanceof between null and DateTimeImmutable will always evaluate to false.
------ ------------------------------------------------------------------------------
I've been trying other ways, but none worked 😞
There was a problem hiding this comment.
Yeah, indeed the eval makes things worse... thanks for explaining!
malarzm
approved these changes
Jun 21, 2021
malarzm
approved these changes
Jun 21, 2021
|
Thanks @franmomu! |
alcaeus
reviewed
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now we are using level 7 of psalm, I raised it locally to level 6 and this PR fixes some of the issues that I think they are easy to review and only in
testsdirectory.The first commits are not SA related, just some polishing.
For the remaning ones I'll open another PR.