Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests directory to phpstan #2317

Merged
merged 8 commits into from
Jun 2, 2021
Merged

Add tests directory to phpstan #2317

merged 8 commits into from
Jun 2, 2021

Conversation

franmomu
Copy link
Contributor

To see the errors, after #2311 there should be way less.

@franmomu franmomu mentioned this pull request May 26, 2021
Merged
@alcaeus
Copy link
Member

alcaeus commented May 31, 2021

@franmomu What do you think about generating a baseline for the tests directory, document how to update this baseline, and defer fixing these to future pull requests? I believe enforcing stricter rules for new code makes sense, and might also help with fixing some existing failures. If so, I'm fine merging this PR with a baseline.

@franmomu
Copy link
Contributor Author

@franmomu What do you think about generating a baseline for the tests directory, document how to update this baseline, and defer fixing these to future pull requests? I believe enforcing stricter rules for new code makes sense, and might also help with fixing some existing failures. If so, I'm fine merging this PR with a baseline.

Yeah sure, let's wait for #2311 to be merged so the baseline would be quite smaller.

@alcaeus
Copy link
Member

alcaeus commented May 31, 2021

Yeah sure, let's wait for #2311 to be merged so the baseline would be quite smaller.

Done! 👍

@franmomu franmomu mentioned this pull request Jun 1, 2021
Merged
@franmomu franmomu force-pushed the phpstan_tests branch 2 times, most recently from 38943da to 7a8c866 Compare June 1, 2021 13:21
@franmomu franmomu changed the title [WIP] Add test directory to phpstan Add test directory to phpstan Jun 1, 2021
@franmomu franmomu changed the title Add test directory to phpstan Add tests directory to phpstan Jun 1, 2021
@alcaeus alcaeus self-assigned this Jun 2, 2021
@alcaeus alcaeus added the Task label Jun 2, 2021
@alcaeus alcaeus added this to the 2.3.0 milestone Jun 2, 2021
@alcaeus alcaeus merged commit 894ee25 into doctrine:2.3.x Jun 2, 2021
@alcaeus
Copy link
Member

alcaeus commented Jun 2, 2021

Thanks @franmomu!

@franmomu franmomu deleted the phpstan_tests branch June 2, 2021 11:33
@alcaeus alcaeus modified the milestones: 2.3.0-alpha1, 2.3.0 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
Task
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @alcaeus