Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping of the nullable option for XML driver #2297

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Fix mapping of the nullable option for XML driver #2297

merged 1 commit into from
Mar 16, 2021

Conversation

wuchen90
Copy link
Contributor

@wuchen90 wuchen90 commented Mar 15, 2021 •
edited
Loading

Q A
Type bug
BC Break no
Fixed issues #2295

Summary

  • Fix XML driver to map the attribute nullable for basic fields.
  • Fix for embed documents.
  • Fix for reference documents.
  • Add tests.

@wuchen90 wuchen90 mentioned this pull request Mar 15, 2021
Closed
@malarzm malarzm added the Bug label Mar 15, 2021
@malarzm malarzm added this to the 2.2.1 milestone Mar 15, 2021
@malarzm
Copy link
Member

malarzm commented Mar 16, 2021

Thanks a lot @wuchen90!

@malarzm malarzm linked an issue Mar 16, 2021 that may be closed by this pull request
XML mapping doesn't take account of the attribute nullable for embedded document #2295
Closed
@malarzm malarzm merged commit 6e42eed into doctrine:2.2.x Mar 16, 2021
@wuchen90 wuchen90 deleted the fix-xml-nullable branch March 16, 2021 14:41
@github-actions github-actions bot mentioned this pull request May 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malarzm malarzm malarzm approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

XML mapping doesn't take account of the attribute nullable for embedded document
2 participants
@wuchen90 @malarzm