Set type maps on collection level #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
collection-level-typemaps
branch
from
5c9f363 to
38691a4
Compare
malarzm
approved these changes
Feb 26, 2021
SenseException
approved these changes
Feb 26, 2021
|
@malarzm I went for the next minor version since it's a behavioural change. No rush on this one 😊 |
This was referenced Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the experience for users that create their own
MongoDB\Clientinstance for the document manager. Instead of having to set the appropriate type map, ODM will now apply the type map on the collection level when callinggetDocumentCollection. The end result is the same, as the type map gets applied to every operation (unless the operation has is own type map).