Introduce aggregation API to replicate query API #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
approved these changes
Jul 22, 2020
alcaeus
force-pushed
the
aggregation-instance
branch
from
fb5835e to
222334b
Compare
|
@malarzm updated UPGRADE documents and updated documentation. Mind giving it another look please? |
malarzm
approved these changes
Jul 23, 2020
UPGRADE-3.0.md
Outdated
| comparable to the `Query` class. | ||
|
|
||
| The `Doctrine\ODM\MongoDB\Aggregation\Builder::execute()` method was deprecated | ||
| and will be removed in ODM 3.0. |
There was a problem hiding this comment.
In context of 3.0 this (and other sentences) should be written with the past tense I think :) But I have no problem with doing so in another PR
There was a problem hiding this comment.
That was the original intention, but I goofed up. It's fixed now.
alcaeus
force-pushed
the
aggregation-instance
branch
from
e777dcc to
dc52f23
Compare
malarzm
approved these changes
Jul 24, 2020
|
Thanks @alcaeus! |
DavideTriso
added a commit
to DavideTriso/mongodb-odm
that referenced
this pull request
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces a new
Aggregationclass, that can be created from an aggregation builder using thegetAggregationmethod. Theexecutemethod on the aggregation builder has been deprecated in favour of the new API.Rationale
The query builder returns a query instance that can be passed around without executing the query, but also disallowing changes to the query. The aggregation builder on the other hand only returns an iterator that may or may not have already executed something on the database. Passing the aggregation builder around opens it up to modification that may not be intended.