Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneceesary internal designations #2123

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Remove unneceesary internal designations #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Doctrine/ODM/MongoDB/DocumentManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,6 @@ public function getSchemaManager()
*
* @param string $className The class name.
* @return \Doctrine\ODM\MongoDB\Mapping\ClassMetadata
* @internal Performance-sensitive method.
*/
public function getClassMetadata($className)
{
Expand Down
3 changes: 0 additions & 3 deletions lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,9 +578,6 @@ public function slice($offset, $length = null)
/**
* Called by PHP when this collection is serialized. Ensures that the
* internal state of the collection can be reproduced after serialization
*
* @internal Tried to implement Serializable first but that did not work well
* with circular references. This solution seems simpler and works well.
*/
public function __sleep()
{
Expand Down
2 changes: 0 additions & 2 deletions lib/Doctrine/ODM/MongoDB/UnitOfWork.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2047,7 +2047,6 @@ public function detach($document)
*
* @param object $document
* @param array $visited
* @internal This method always considers documents with an assigned identifier as DETACHED.
*/
private function doDetach($document, array &$visited)
{
Expand Down Expand Up @@ -2697,7 +2696,6 @@ public function getClassNameForAssociation(array $mapping, $data)
* @param array $hints Any hints to account for during reconstitution/lookup of the document.
* @param object $document The document to be hydrated into in case of creation
* @return object The document instance.
* @internal Highly performance-sensitive method.
*/
public function getOrCreateDocument($className, $data, &$hints = array(), $document = null)
{
Expand Down