Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 5 support #2115

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Symfony 5 support #2115

merged 1 commit into from
Nov 25, 2019

Conversation

chalasr
Copy link
Contributor

@chalasr chalasr commented Nov 20, 2019

Q A
Type improvement
BC Break no
Fixed issues -

@alcaeus
Copy link
Member

alcaeus commented Nov 21, 2019

@chalasr same as doctrine/DoctrineMongoDBBundle#602 (comment), I'll add tests for Symfony 5 as well. Thanks for starting this!

@michalbundyra michalbundyra mentioned this pull request Nov 23, 2019
Closed
@alcaeus alcaeus changed the base branch from master to 1.3.x November 24, 2019 06:30
@alcaeus alcaeus force-pushed the sf5 branch 2 times, most recently from 76a89b8 to 962237c Compare November 24, 2019 06:59
@michalbundyra michalbundyra mentioned this pull request Nov 24, 2019
Closed
@michalbundyra
Copy link
Member

@alcaeus the changes here are not full to make the library compatible with Symfony 5.0 modules. That's why I've created my PR which has been closed - #2119 but was addressed to branch 1.3.x.

@alcaeus alcaeus self-assigned this Nov 25, 2019
@alcaeus alcaeus added this to the 1.3.5 milestone Nov 25, 2019
@alcaeus
Copy link
Member

alcaeus commented Nov 25, 2019

Thanks @chalasr! Testing will have to wait until phpbench supports Symfony 5 (which again is waiting on php-cs-fixer).

@alcaeus alcaeus merged commit e04f5ff into doctrine:1.3.x Nov 25, 2019
@chalasr chalasr deleted the sf5 branch November 26, 2019 01:02
@doctrinebot doctrinebot mentioned this pull request Nov 26, 2019
Merged
@SenseException SenseException mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
Enhancement
Projects
None yet
Milestone
1.3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @alcaeus @michalbundyra