Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Fix wrong syntax for replaceRoot stage #2041

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Jul 9, 2019

Q A
Type bug
BC Break no
Fixed issues doctrine/DoctrineMongoDBBundle#565

Summary

This ports the changes from doctrine/mongodb#333 to the master branch which now includes the main logic. For 1.x, the fix is done in doctrine/mongodb, we just need to update the tests once a fix is released.

@alcaeus alcaeus added the Bug label Jul 9, 2019
@alcaeus alcaeus added this to the 2.0.0 milestone Jul 9, 2019
@alcaeus alcaeus requested a review from jmikola July 9, 2019 20:16
@alcaeus alcaeus self-assigned this Jul 9, 2019
@alcaeus alcaeus force-pushed the fix-replaceroot-syntax branch from ed02702 to daed76c Compare July 10, 2019 18:34
@alcaeus alcaeus force-pushed the fix-replaceroot-syntax branch 2 times, most recently from b678b7d to 7b6ca77 Compare July 11, 2019 15:23
@alcaeus alcaeus force-pushed the fix-replaceroot-syntax branch from 7b6ca77 to 10270e3 Compare July 12, 2019 07:08
@alcaeus alcaeus merged commit fb8c92b into doctrine:master Jul 16, 2019
@alcaeus alcaeus deleted the fix-replaceroot-syntax branch July 16, 2019 10:10
@alcaeus alcaeus modified the milestones: 2.0.0, 2.0.0-RC2 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants