add mergeObjects() function #1897
Conversation
There was a problem hiding this comment.
Thank you for your contribution. Apart from the comments below, please note the following:
- Please add tests as they are there for other aggregation pipeline operators. Take a look at
AggregationOperatorsProviderTraitfor guidance. - Just adding the operator to
Exprdoesn't help, you also need to expose it in theOperatorclass.
We'll have to see how to deal with the two different syntaxes for $mergeObjects: it can take a single argument (e.g. when used as accumulator in a $group stage) or 2 or more arguments (when used in other stages or operators). This also affects some other operators (e.g. $min and $max and currently isn't properly handled).
Please also note that I'm scheduling this for 2.1 as we've got a whole load of aggregation operators that need adding. You can always create the operator manually through the expression helper in the meantime.
| * | ||
| * @see http://docs.mongodb.com/manual/reference/operator/aggregation/mergeObjects/ | ||
| * | ||
| * @param Object1,Object2,... |
There was a problem hiding this comment.
This typehint is wrong, please refer to other methods for guidance.
| * | ||
| * @param Object1,Object2,... | ||
| */ | ||
| public function mergeObjects() |
There was a problem hiding this comment.
Please look at other methods as to how to handle these arguments. Looking at the documentation for this operator, you can use $expression1, $expression2, ...$expressions and appropriate @param blocks. The add helper has a similar signature.
| */ | ||
| public function mergeObjects() | ||
| { | ||
| $arrayarg = array(); |
There was a problem hiding this comment.
There's no need to copy the contents of func_get_args in a separate array, just pass them to the operator helper directly (again, see the add helper for example).
| @@ -907,7 +907,23 @@ public function max($expression) : self | |||
| { | |||
| return $this->operator('$max', $expression); | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
There are trailing spaces in this line which must not be there.
|
|
Summary