[2.0] Separate ID mapping from fields in XML driver #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
approved these changes
Jun 6, 2018
alcaeus
added a commit
to alcaeus/mongodb-odm
that referenced
this pull request
Jan 9, 2019
Merged
alcaeus
added a commit
to alcaeus/mongodb-odm
that referenced
this pull request
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts identifier options from the
fieldtag in the XML mapping and moves it to a newidfield. This is done to make it easier to map identifiers and to have fewer incompatibilities to take care of (e.g. it doesn't make sense to specify generator options on non-identifier fields and identifiers can't take many of the options available to regular fields). It also brings identifier mappings more in-line with what we're planning to do with GridFS fields (see #1790).Note: this change needs to be backported to 1.3, along with a deprecation warning about
id="true"being removed in 2.0.