Add CustomType class to let use convertToPHPValue method instead of closureToPHP #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgonzalezbaile
changed the title
mgonzalezbaile
commented
Oct 12, 2016
| // Note: this code ends up in the generated hydrator class (via HydratorFactory) | ||
| public function closureToPHP() | ||
| { | ||
| return '$return = array_map(function($v) { if ($v instanceof \MongoDate) { $date = new \DateTime(); $date->setTimestamp($v->sec); return $date; } else { return new \DateTime($v); } }, $value);'; |
There was a problem hiding this comment.
Just extracted the code from quotes and put it inside convertToPHPValue while keeping the test green.
malarzm
requested changes
Oct 14, 2016
|
|
||
| return sprintf(' | ||
| $reflection = new \ReflectionClass("%s"); | ||
| $type = $reflection->newInstanceWithoutConstructor(); |
There was a problem hiding this comment.
I think that instead of using reflection we could add a method that would get Type instance by its FQCN
There was a problem hiding this comment.
If I am not missing anything, in order to get the instance of Type I can do it by:
- constructor: which is defined as
final privatein the base class. - factory method: current factory methods instantiate
Typefrom the custom type identifier (key in$typesMaparray fromTypeclass). I don't see a way to get the custom type identifier so I can make use of any factory method.
Am I right?
There was a problem hiding this comment.
I have pushed PR #1513 avoiding reflection to instantiate Type, let me know your thoughts.
|
Closing in favour of #1513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1509