Fix changeset missing old value for exchanged associations #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way
from original PR seem to no longer be true however I haven't tested that |
If that's something we want, I'd add a quick test to it, if not I'd also add a quick test to make sure it isn't so ;) |
|
As much as I admire the idea I'm pretty sure we'll get into troubles soon, for example I have quite bad feelings about including |
|
Sounds like a plan 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug while working on new change sets; in #1339 I was so happy that collections are in the change set that I haven't checked what was in the change set :) By the way fixed the same thing for when embedded document is exchanged.