Merge remote-tracking branch 'upstream/1.3.x' into 1.3.x-merge-up-int…

…o-2.0.x_5ddcd836c41c12.43134100 * upstream/1.3.x: Remove unneceesary internal designations
doctrine · Nov 26, 2019 · c8b27c1 · c8b27c1
2 parents 9d4b3f0 + 3bfedc0
commit c8b27c1
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/lib/Doctrine/ODM/MongoDB/DocumentManager.php b/lib/Doctrine/ODM/MongoDB/DocumentManager.php
@@ -277,8 +277,6 @@ public function getClassNameResolver() : ClassNameResolver
     /**
      * Returns the metadata for a class.
      *
-     * @internal Performance-sensitive method.
-     *
      * @param string $className The class name.
      */
     public function getClassMetadata($className) : ClassMetadata

diff --git a/lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php b/lib/Doctrine/ODM/MongoDB/PersistentCollection/PersistentCollectionTrait.php
@@ -589,9 +589,6 @@ public function slice($offset, $length = null)
     /**
      * Called by PHP when this collection is serialized. Ensures that the
      * internal state of the collection can be reproduced after serialization
-     *
-     * @internal Tried to implement Serializable first but that did not work well
-     *           with circular references. This solution seems simpler and works well.
      */
     public function __sleep()
     {

diff --git a/lib/Doctrine/ODM/MongoDB/UnitOfWork.php b/lib/Doctrine/ODM/MongoDB/UnitOfWork.php
@@ -1891,8 +1891,6 @@ public function detach(object $document) : void
 
     /**
      * Executes a detach operation on the given document.
-     *
-     * @internal This method always considers documents with an assigned identifier as DETACHED.
      */
     private function doDetach(object $document, array &$visited) : void
     {
@@ -2531,8 +2529,6 @@ public function getClassNameForAssociation(array $mapping, $data) : string
 
     /**
      * Creates a document. Used for reconstitution of documents during hydration.
-     *
-     * @internal
      */
     public function getOrCreateDocument(string $className, array $data, array &$hints = [], ?object $document = null) : object
     {