Skip to content

Commit

Permalink
Remove some iterable types
Browse files Browse the repository at this point in the history
They don't add value
  • Loading branch information
franmomu committed Nov 5, 2022
1 parent fee2938 commit babf193
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
5 changes: 5 additions & 0 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -237,3 +237,8 @@ parameters:
message: "#^Call to an undefined method ReflectionEnum\\:\\:getBackingType\\(\\)\\.$#"
count: 1
path: lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php

-
message: "#has parameter \\$[^\\s]+ with no value type specified in iterable type array\\.$#"
count: 6
path: tests/*
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ public function testMatchFromBuilder(): void
}

/**
* @param mixed[] $args
*
* @dataProvider provideProxiedExprMethods
*/
public function testProxiedExprMethods(string $method, array $args = []): void
Expand Down
3 changes: 0 additions & 3 deletions tests/Doctrine/ODM/MongoDB/Tests/BaseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ protected function getConfiguration(): Configuration
* the original assertion checked.
*
* @deprecated
*
* @param mixed[] $subset
* @param mixed[] $array
*/
public static function assertArraySubset(array $subset, array $array, bool $checkForObjectIdentity = false, string $message = ''): void
{
Expand Down
8 changes: 2 additions & 6 deletions tests/Doctrine/ODM/MongoDB/Tests/Query/BuilderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -474,8 +474,6 @@ public function testDeepClone(): void
}

/**
* @param mixed[] $args
*
* @dataProvider provideProxiedExprMethods
*/
public function testProxiedExprMethods(string $method, array $args = []): void
Expand Down Expand Up @@ -569,8 +567,7 @@ public function providePoint(): array
}

/**
* @param string[] $args
* @param array<string, 1> $expected
* @param string[] $args
*
* @dataProvider provideSelectProjections
*/
Expand All @@ -588,8 +585,7 @@ public function provideSelectProjections(): array
}

/**
* @param string[] $args
* @param array<string, 0> $expected
* @param string[] $args
*
* @dataProvider provideExcludeProjections
*/
Expand Down

0 comments on commit babf193

Please sign in to comment.