Fix Psalm errors

doctrine · Sep 20, 2022 · 36827e4 · 36827e4
1 parent a53f3ac
commit 36827e4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/lib/Doctrine/ODM/MongoDB/DocumentManager.php b/lib/Doctrine/ODM/MongoDB/DocumentManager.php
@@ -621,13 +621,15 @@ public function getReference(string $documentName, $identifier): object
         /** @psalm-var ClassMetadata<T> $class */
         $class = $this->metadataFactory->getMetadataFor(ltrim($documentName, '\\'));
         assert($class instanceof ClassMetadata);
+        /** @psalm-var T|false $document */
         $document = $this->unitOfWork->tryGetById($identifier, $class);
 
         // Check identity map first, if its already in there just return it.
-        if ($document) {
+        if ($document !== false) {
             return $document;
         }
 
+        /** @psalm-var T&GhostObjectInterface<T> $document */
         $document = $this->proxyFactory->getProxy($class, $identifier);
         $this->unitOfWork->registerManaged($document, $identifier, []);
 
@@ -689,6 +691,7 @@ public function find($className, $id, $lockMode = LockMode::NONE, $lockVersion =
     {
         $repository = $this->getRepository($className);
         if ($repository instanceof DocumentRepository) {
+            /** @psalm-var DocumentRepository<T> $repository */
             return $repository->find($id, $lockMode, $lockVersion);
         }
 

diff --git a/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php b/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php
@@ -2247,7 +2247,7 @@ public function mapField(array $mapping): array
                     break;
                 default:
                     if (! empty($this->generatorOptions['type'])) {
-                        $mapping['type'] = $this->generatorOptions['type'];
+                        $mapping['type'] = (string) $this->generatorOptions['type'];
                     } elseif (empty($mapping['type'])) {
                         $mapping['type'] = $this->generatorType === self::GENERATOR_TYPE_INCREMENT ? Type::INT : Type::CUSTOMID;
                     }

diff --git a/lib/Doctrine/ODM/MongoDB/UnitOfWork.php b/lib/Doctrine/ODM/MongoDB/UnitOfWork.php
@@ -367,6 +367,7 @@ public function getDocumentPersister(string $documentName): Persisters\DocumentP
             $this->persisters[$documentName] = new Persisters\DocumentPersister($pb, $this->dm, $this, $this->hydratorFactory, $class);
         }
 
+        /** @psalm-var Persisters\DocumentPersister<T> */
         return $this->persisters[$documentName];
     }
 

diff --git a/tests/Doctrine/ODM/MongoDB/Tests/Repository/DefaultGridFSRepositoryTest.php b/tests/Doctrine/ODM/MongoDB/Tests/Repository/DefaultGridFSRepositoryTest.php
@@ -268,6 +268,7 @@ private function getRepository(string $className = File::class): GridFSRepositor
 
         assert($repository instanceof GridFSRepository);
 
+        /** @psalm-var GridFSRepository<T> */
         return $repository;
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                 $this->persisters[$documentName] = new Persisters\DocumentPersister($pb, $this->dm, $this, $this->hydratorFactory, $class);
             }
+            /** @psalm-var Persisters\DocumentPersister<T> */
             return $this->persisters[$documentName];
         }
@@ Expand Down @@