Change the column length of the version column to default to 14 #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jan 2, 2019
| @@ -43,7 +43,7 @@ class Configuration | |||
| private $migrationsColumnName = 'version'; | |||
|
|
|||
| /** @var int */ | |||
| private $migrationsColumnLength = 255; | |||
| private $migrationsColumnLength = 14; | |||
There was a problem hiding this comment.
Suggested change
| private $migrationsColumnLength = 14; | |
| private $migrationsColumnLength = 14; // strlen((new \DateTime())->format('YmdHis')) |
Or maybe initialize it with that call in the constructor?
There was a problem hiding this comment.
What is your reasoning for wanting to do it that way?
There was a problem hiding this comment.
Magic numbers are code smells I try to avoid by always showing what they represent, be it by using a constant, or showing what computation gave that result. For instance, I would use 60 * 60 * 24 * instead of 86400.
jwage
force-pushed
the
change-default-version-length
branch
from
4a2e19c to
67b875e
Compare
greg0ire
approved these changes
Jan 2, 2019
Majkl578
suggested changes
Jan 2, 2019
mhujer
added a commit
to mhujer/migrations
that referenced
this pull request
Jan 19, 2019
Merged
jwage
pushed a commit
that referenced
this pull request
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #772
The version column by default is only 14 characters so we don't need to create a varchar(255) by default. This also causes issues with MariaDB see #514 and #538 and doctrine/DoctrineMigrationsBundle#247