Reorganize classes for 2.0 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwage
force-pushed
the
reorganize-classes
branch
2 times, most recently
from
c96f84d to
ad4a098
Compare
Majkl578
reviewed
May 31, 2018
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| declare(strict_types=1); | |||
|
|
|||
| namespace Doctrine\Migrations; | |||
| namespace Doctrine\Migrations\MigrationTable; | |||
There was a problem hiding this comment.
How about calling this Storage/Tracking/Persistence?
|
Can we somehow also rename MigratorConfig? At least replacing the abbreviation (MigratorConfiguration). |
morozov
reviewed
May 31, 2018
| @@ -9,3 +9,5 @@ phpunit.xml | |||
| /phpcs.xml | |||
| /.phpcs-cache | |||
| /box.phar | |||
| /.idea | |||
There was a problem hiding this comment.
IMO, this line belongs to a personal .gitignore file but not to the project, unless the project is tightly coupled to the IDE.
There was a problem hiding this comment.
I didn't know you could do that. I will remove it and do that. Thanks!
There was a problem hiding this comment.
IMO, this line belongs to a personal
.gitignorefile
👍
There is nice article from GitHub: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we refactored, several new classes were created and put in the root namespace. Move the logical groupings in to folders.