Always store executed_at in UTC and render using date_default_timezone() #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majkl578
suggested changes
May 30, 2018
Majkl578
reviewed
May 30, 2018
lib/Doctrine/Migrations/Version.php
Outdated
| @@ -221,7 +226,7 @@ private function getWriteSqlFileMigratorConfig() : MigratorConfig | |||
| private function getExecutedAtDatabaseValue() : string | |||
| { | |||
| return Type::getType(MigrationTable::MIGRATION_EXECUTED_AT_COLUMN_TYPE)->convertToDatabaseValue( | |||
| new DateTimeImmutable(), | |||
| (new DateTimeImmutable('now', new DateTimeZone(date_default_timezone_get())))->setTimezone(new DateTimeZone('UTC')), | |||
There was a problem hiding this comment.
You can drop new DateTimeZone(date_default_timezone_get())), it's default behavior.
Majkl578
reviewed
May 30, 2018
| { | ||
| $originalTimeZone = date_default_timezone_get(); | ||
|
|
||
| date_default_timezone_set($timeZone); |
There was a problem hiding this comment.
I'd put whole test after this statement inside try { ... } and then date_default_timezone_set($originalTimeZone); inside finally, otherwise when the test fails, the timezone will stay messed up.
There was a problem hiding this comment.
FIWI, there's TestCase::iniSet() which could be use to simplify the cleanup. Also, it will throw an explicit exception in the case of a failure and fail the test.
There was a problem hiding this comment.
Cool, didn't know it exists. 👍
| { | ||
| return [ | ||
| ['America/New_York'], | ||
| ['Indian/Chagos'], |
There was a problem hiding this comment.
Would maybe also add 'UTC'? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Always store executed_at in UTC and render using date_default_timezone()