Use Symfony Stopwatch for timing and memory. #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwage
force-pushed
the
use-symfony-stopwatch
branch
from
128532b to
0707597
Compare
jwage
force-pushed
the
use-symfony-stopwatch
branch
from
0707597 to
fbdd06d
Compare
stof
reviewed
May 17, 2018
| { | ||
| public function start(string $section) : StopwatchEvent | ||
| { | ||
| $stopwatch = new SymfonyStopwatch(true); |
There was a problem hiding this comment.
why creating a new SymfonyStopwatch each time ?
There was a problem hiding this comment.
@stof This may have been a misunderstanding on my part of how Stopwatch behaves. Looking at the code now I see that I can have one instance of it. I will make a PR to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the Symfony stopwatch for timing and memory monitoring.