-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Symfony 3.4 in Doctrine Migration 2.0 as 3.4 is a LTS release. #653
Conversation
@jwage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev-dependency is irrelevant and should stay 4.0-only, but symfony/console is what this is about :)
composer.json
Outdated
@@ -14,7 +14,7 @@ | |||
"php": "^7.1", | |||
"doctrine/dbal": "^2.6", | |||
"ocramius/proxy-manager": "^2.0.2", | |||
"symfony/console": "^4.0" | |||
"symfony/console": "^3.4|^4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using ||
as the OR operator rather than the older |
to follow the composer recommendation (choosing the double pipe as the main operator was done because it is also the operator used by ruby's bundler and by npm, making the syntax consistent between package managers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doctrine uses single pipe everywhere currently. Could you point to the recommendation and ideally to deprecation of current format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecation is not planned (it would break all existing releases using it, so it is almost impossible to deprecate anything there). But the older operators have been removed from the composer doc in favor of new ones (this was done when updating the doc in composer/composer@ebab9db)
🎉 |
Fixes #651