Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 3.4 in Doctrine Migration 2.0 as 3.4 is a LTS release. #653

Merged
merged 1 commit into from
May 7, 2018

Conversation

jwage
Copy link
Member

@jwage jwage commented May 7, 2018

Fixes #651

@jwage jwage self-assigned this May 7, 2018
@jwage jwage added this to the 2.0 milestone May 7, 2018
@emodric
Copy link
Contributor

emodric commented May 7, 2018

@jwage symfony/console dependency should also be updated :)

Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-dependency is irrelevant and should stay 4.0-only, but symfony/console is what this is about :)

@jwage jwage force-pushed the symfony-3.4-support branch from 7e8fbf7 to f3df54c Compare May 7, 2018 14:35
@jwage
Copy link
Member Author

jwage commented May 7, 2018

@Majkl578 @emodric updated.

composer.json Outdated
@@ -14,7 +14,7 @@
"php": "^7.1",
"doctrine/dbal": "^2.6",
"ocramius/proxy-manager": "^2.0.2",
"symfony/console": "^4.0"
"symfony/console": "^3.4|^4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using || as the OR operator rather than the older | to follow the composer recommendation (choosing the double pipe as the main operator was done because it is also the operator used by ruby's bundler and by npm, making the syntax consistent between package managers)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doctrine uses single pipe everywhere currently. Could you point to the recommendation and ideally to deprecation of current format?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecation is not planned (it would break all existing releases using it, so it is almost impossible to deprecate anything there). But the older operators have been removed from the composer doc in favor of new ones (this was done when updating the doc in composer/composer@ebab9db)

@jwage jwage force-pushed the symfony-3.4-support branch from f3df54c to 13c817a Compare May 7, 2018 14:49
@jwage jwage merged commit 2fb607a into master May 7, 2018
@jwage jwage deleted the symfony-3.4-support branch May 7, 2018 21:54
@emodric
Copy link
Contributor

emodric commented May 7, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants