Add PHPStan strict rules

[Majkl578]

No description provided.

[localheinz]

How about keeping packages sorted?

See https://getcomposer.org/doc/06-config.md#sort-packages or https://github.com/localheinz/composer-normalize.

[lcobucci]

I know that this might be a premature optimisation and that doctrine/migrations is not really sensitive regarding performance, but comparing with an empty array is faster than using count - even with PHP 7.2 optimisations - so I'd suggest to use if ($this->migrations !== []) { instead.

[lcobucci]

Simple bench:

<?php

namespace Blah;

use function assert;
use function count;

/**
 * @BeforeMethods({"init"})
 */
final class ArrayBench
{
    private $data;

    public function init(): void
    {
        $this->data = array_fill(0, 10000000, 'banana');
    }

    /**
     * @Revs(1000)
     * @Iterations(5)
     */
    public function benchCount()
    {
        assert(count($this->data) !== 0);
    }

    /**
     * @Revs(1000)
     * @Iterations(5)
     */
    public function benchComparison()
    {
        assert($this->data !== []);
    }
}

Result:

PhpBench 0.14-dev (60dfc50). Running benchmarks.
Using configuration file: /Users/luis/projects/chimera/bus-tactician/blah/phpbench.json

\Blah\ArrayBench

    benchCount                    I4 P0 	[μ Mo]/r: 0.092 0.092 (μs) 	[μSD μRSD]/r: 0.001μs 0.69%
    benchComparison               I4 P0 	[μ Mo]/r: 0.089 0.089 (μs) 	[μSD μRSD]/r: 0.000μs 0.55%

2 subjects, 10 iterations, 2,000 revs, 0 rejects
(best [mean mode] worst) = 0.088 [0.090 0.090] 0.089 (μs)
⅀T: 0.903μs μSD/r 0.001μs μRSD/r: 0.620%

[lcobucci]

Obviously that the size of the array and the data it contains would also affect the benchmark.

[lcobucci]

@Majkl578 I'll merge it now so we can discuss this and eventually change (or not)

[Majkl578]

We had discussion about this few days ago on Slack.
The difference is so minimal that I decided to ignore it completely. (Tens of miliseconds on 100 milion operations.)
Approach with count() is more future proof, if we eventually decide to introduce i.e. a) first class collections or b) php-ds.
The difference is not by factor of 100, not even by 100, in fact it's like 5%-10%. Using ! is much safer but that takes us to non-strict land and we don't want to go that path,

See https://gist.github.com/Majkl578/8fd1dec6b9e005e53c247a4953ccebbf

[lcobucci]

❤️ I can't wait to have PHPStan v0.10 stable

[lcobucci]

@Majkl578 🚢