Enable SchemaManagerFunctionalTestCase::testQuotedIdentifiers() for more platforms #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
enable-test-quoted-identifiers-for-all-platforms
branch
from
1df0509 to
1c843a0
Compare
morozov
commented
Feb 4, 2025
| @@ -214,15 +214,15 @@ public function testNonSimpleAlterTableCreatedFromDDL(): void | |||
|
|
|||
| $table1 = $schemaManager->introspectTable('nodes'); | |||
| $table2 = clone $table1; | |||
| $table2->addIndex(['name'], 'idx_name'); | |||
| $table2->addIndex(['name'], 'idx_node_name'); | |||
There was a problem hiding this comment.
Apparently, index names in SQLite are global, so I renamed the one here and in the other test which now also runs on SQLite.
morozov
force-pushed
the
enable-test-quoted-identifiers-for-all-platforms
branch
from
1c843a0 to
996fb41
Compare
morozov
changed the title
greg0ire
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DBAL 5, all identifiers are quoted in SQL, regardless of whether they are declared as quoted or not. This enables running the tests on
allalmost all platforms. We can enable DB2 once we introspect all identifiers as quoted by default.