Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symfony tests listener #3090

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Apr 5, 2018

It is required when using annotations to detect deprecation errors.

@greg0ire greg0ire changed the base branch from master to 2.7 April 5, 2018 07:40
@greg0ire greg0ire force-pushed the add_missing_listener branch from 50d33e0 to eb1de46 Compare April 5, 2018 07:42
It is required when using annotations to detect deprecation errors.
@greg0ire
Copy link
Member Author

greg0ire commented Apr 5, 2018

Rebased

@Majkl578 Majkl578 changed the base branch from 2.7 to master April 5, 2018 13:55
@greg0ire
Copy link
Member Author

greg0ire commented Apr 5, 2018

Uuuuh why did you change that back to master @Majkl578 ? 2.7 uses the listener:

<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />

@Majkl578
Copy link
Contributor

Majkl578 commented Apr 5, 2018

All PRs are supposed to target and be merged to master. Backporting is up to maintainers.

@greg0ire
Copy link
Member Author

greg0ire commented Apr 5, 2018

TIL

@Majkl578 Majkl578 merged commit 4c34c70 into doctrine:master Apr 5, 2018
@greg0ire greg0ire deleted the add_missing_listener branch April 5, 2018 17:03
Majkl578 added a commit to Majkl578/doctrine-dbal that referenced this pull request Apr 6, 2018
@Majkl578
Copy link
Contributor

Majkl578 commented Apr 7, 2018

Backported into 2.7 @ 62be858

@Majkl578 Majkl578 self-assigned this Apr 7, 2018
rgrellmann added a commit to Rossmann-IT/dbal that referenced this pull request Apr 13, 2018
This release fixes unintentional BC breaks:

1. It was impossible to use deprecated fetch modes with PDO-based drivers.
2. An unsupported option passed to the `Column` object prevented subsequent options from being applied.
3. Date interval values stored prior to upgrade to `v2.7.0` were reported as invalid.

Total issues resolved: **10**

**Backwards Compatibility Fixes:**

- [3082: Custom PDO fetch modes and 2.7.0](doctrine#3082) thanks to @corphi
- [3088: Fix doctrine#3082: Add BC for PDO-only fetch modes](doctrine#3088) thanks to @corphi
- [3089: Don't skip column options.](doctrine#3089) thanks to @andytruong
- [3093: When updating to version v2.7 type DateInterval throws errors](doctrine#3093) thanks to @fnagel
- [3097: Fix compatibility for pre-2.7 DateIntervalType format](doctrine#3097) thanks to @Majkl578

**Documentation Improvements:**

- [3083: Document the correct way of configuring a MariaDB database with serverVersion](doctrine#3083) thanks to @tristanbes
- [3084: README: Add 2.7, drop 2.5](doctrine#3084) thanks to @Majkl578

**Continuous Integration Improvements:**

- [3085: Tests: remove implicit verbose flag](doctrine#3085) thanks to @Majkl578
- [3090: Add symfony tests listener](doctrine#3090) thanks to @greg0ire
- [3095: CI: Add missing listener for MariaDB @ mysqli](doctrine#3095) thanks to @Majkl578

# gpg: directory `/n/.gnupg' created
# gpg: new configuration file `/n/.gnupg/gpg.conf' created
# gpg: WARNING: options in `/n/.gnupg/gpg.conf' are not yet active during this run
# gpg: DBG: locking for `/n/.gnupg/pubring.gpg.lock' done via O_EXCL
# gpg: keyring `/n/.gnupg/pubring.gpg' created
# gpg: Signature made Sun Apr  8 07:24:49 2018     using RSA key ID 543AE995
# gpg: Can't check signature: public key not found

# Conflicts:
#	.gitignore
#	lib/Doctrine/DBAL/Driver/OCI8/Driver.php
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants