Merge pull request #6755 from morozov/deprecate-get-portable-table-de…

…finition

Deprecate `AbstractSchemaManager::_getPortableTableDefinition()`

UPGRADE.md

@@ -8,6 +8,11 @@ awareness about deprecated code.
 
 # Upgrade to 4.3
 
+## Deprecated `AbstractSchemaManager::_getPortableTableDefinition()`
+
+The `AbstractSchemaManager::_getPortableTableDefinition()` method has been deprecated. Use the schema name and the
+unqualified table name separately instead.
+
 ## Deprecated `PostgreSQLSchemaManager` methods related to the current schema
 
 The following `PostgreSQLSchemaManager` methods have been deprecated:

src/Schema/AbstractSchemaManager.php

@@ -837,7 +837,11 @@ protected function _getPortableTableIndexesList(array $rows, string $tableName):
         return $indexes;
     }
 
-    /** @param array<string, string> $table */
+    /**
+     * @deprecated Use the schema name and the unqualified table name separately instead.
+     *
+     * @param array<string, string> $table
+     */
     abstract protected function _getPortableTableDefinition(array $table): string;
 
     /** @param array<string, mixed> $view */

src/Schema/DB2SchemaManager.php

@@ -101,6 +101,8 @@ protected function _getPortableTableColumnDefinition(array $tableColumn): Column
     }
 
     /**
+     * @deprecated Use the schema name and the unqualified table name separately instead.
+     *
      * {@inheritDoc}
      */
     protected function _getPortableTableDefinition(array $table): string

src/Schema/MySQLSchemaManager.php

@@ -61,6 +61,8 @@ class MySQLSchemaManager extends AbstractSchemaManager
     private ?DefaultTableOptions $defaultTableOptions = null;
 
     /**
+     * @deprecated Use the schema name and the unqualified table name separately instead.
+     *
      * {@inheritDoc}
      */
     protected function _getPortableTableDefinition(array $table): string

src/Schema/OracleSchemaManager.php

@@ -43,6 +43,8 @@ protected function _getPortableViewDefinition(array $view): View
     }
 
     /**
+     * @deprecated Use the schema name and the unqualified table name separately instead.
+     *
      * {@inheritDoc}
      */
     protected function _getPortableTableDefinition(array $table): string

src/Schema/PostgreSQLSchemaManager.php

@@ -142,6 +142,8 @@ protected function _getPortableViewDefinition(array $view): View
     }
 
     /**
+     * @deprecated Use the schema name and the unqualified table name separately instead.
+     *
      * {@inheritDoc}
      */
     protected function _getPortableTableDefinition(array $table): string

src/Schema/SQLServerSchemaManager.php

@@ -236,6 +236,8 @@ protected function _getPortableTableForeignKeyDefinition(array $tableForeignKey)
     }
 
     /**
+     * @deprecated Use the schema name and the unqualified table name separately instead.
+     *
      * {@inheritDoc}
      */
     protected function _getPortableTableDefinition(array $table): string

src/Schema/SQLiteSchemaManager.php

@@ -92,6 +92,8 @@ public function listTableForeignKeys(string $table): array
     }
 
     /**
+     * @deprecated Use the schema name and the unqualified table name separately instead.
+     *
      * {@inheritDoc}
      */
     protected function _getPortableTableDefinition(array $table): string