Add parameter types

[GromNaN]

In DoctrineMongoDBBundle, we can't add parameter types to all the classes because they are not defined in the base class or the interface. https://github.com/doctrine/DoctrineMongoDBBundle/pull/812/files#diff-1571e1997e046b65a3fdffae3826e46e2a5a89adcce01ff580557d7eedc536e1R71

Adding parameter types to all the methods should not be an issues for classes that extends them. But it might for interfaces.

Also upgrading to PHP 8.1 is required for some mixed and union types.

[derrabus]

This PR does too many things. Let's start small please.

Let's start with parameter types only. Bumping to 8.1 does not yet feel necessary to me. We should not have many union types in parameters and mixed is the only parameter type that you may add downstream.

[GromNaN]

Indeed, I went too far. Reworking.

[GromNaN]

It did not change the type for ORMPurger::getJoinTableName which requires an union ``.
Also ReferenceRepository::setReferenceIdentity has a `mixed` argument.

Nothing needs to be updated in tests.

[derrabus]

Looks good so far. Once this PR is merged, we might open a 2.0 branch where we bump to 8.1 and apply return types, WDYT?

[derrabus]

Why is the logger a callable anyway? 🙈

[GromNaN]

Line 94.

        $logger = $this->logger;
        $logger($message);

You think we should change it to accept a Psr\Log\LoggerInterface?

[derrabus]

We should look into that, yes. But probably in a separate PR.

[GromNaN]

I'm not going to do that, because it's used for console output directly.

https://github.com/doctrine/DoctrineFixturesBundle/blob/c808a0c85c38c8ee265cc8405b456c1d2b38567d/Command/LoadDataFixturesDoctrineCommand.php#L137-L139

[derrabus]

it's used for console output directly.

We could try to leverage Symfony\Component\Console\Logger\ConsoleLogger. My problem is that a closure is a bad logging abstraction. While it works for the way the bundle uses it, it sucks if you want the logs to go anywhere else, e.g. you want to use a logging framework instead.

Deprecation: #462

[GromNaN]

Once this PR is merged, we might open a 2.0 branch where we bump to 8.1 and apply return types, WDYT?

Sounds like a good idea.
There is little deprecated things to remove, and we could add return types.

[greg0ire]

Thanks @GromNaN !