Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Strict types, native parameter & return types #125

Closed
wants to merge 5 commits into from

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Jul 15, 2017

Migrating code to PHP 7.1:

  • opened 2.0.x-dev
  • enabled strict types
  • added parameter & return types
  • added const visibility
  • added brief upgrading notes

No changes in tests needed except one inheritance violation.

There is no develop branch yet, thus targetting master - let me know how to proceed or when to change base branch. 😎

@psfpro
Copy link

psfpro commented Apr 5, 2018

Hi! What about the slice method? I think slice should return the Collection like filter method.
This will make collection more useful. For example:

$collection->slice(0, 20)->map($func)->toArray();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants