PHP 8.2 Support #728
Merged
PHP 8.2 Support #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driehle
requested changes
Dec 13, 2022
driehle
reviewed
Dec 14, 2022
|
We will have to wait until doctrine/DoctrineModule#796 is merged to get green on 8.2 |
|
@driehle I upgraded DoctrineModule, based on the conversation on doctrine/DoctrineModule#798 |
|
I think before we step deeper into the static analysis issues, it would make sense to provide a PR doing the same as in doctrine/DoctrineModule#792. Then, we can rebase this PR and solve the remaining issues. |
|
@rogervila Could you please rebase on latest 5.3.x? |
driehle
force-pushed
the
php-82-support
branch
from
9046e39 to
9315662
Compare
driehle
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR needs https://github.com/doctrine/DoctrineModule to release a 5.3.x version to support PHP 8.2