Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing view helper "zendDeveloperToolsTime" #496

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Fix: Missing view helper "zendDeveloperToolsTime" #496

merged 1 commit into from
Aug 25, 2016

Conversation

MatthiasKuehneEllerhold
Copy link
Contributor

Fixes the error 'A plugin by the name "zendDeveloperToolsTime" was not found in the plugin manager'

@luads
Copy link

luads commented Aug 19, 2016

Having the same issue here, this change fixed it.

@gianarb
Copy link
Contributor

gianarb commented Aug 23, 2016

Thanks!

@gianarb gianarb added the Bug Something isn't working label Aug 23, 2016
@exptom
Copy link

exptom commented Aug 25, 2016

@gianarb Is it possible to get this merged soon?

@gianarb
Copy link
Contributor

gianarb commented Aug 25, 2016

This fix broke something with people that are using ZF2?

I think yes but I am not sure.. Anyone can try with ZF2? :)

@exptom @lorenzoferrarajr maybe you can help us..

Thanks a lot

@exptom
Copy link

exptom commented Aug 25, 2016

@gianarb There shouldn't be a problem with ZF2. The service names are case-insensitive in ZF2 but they are case sensitive in ZF3.

As you can see the view helper is registered with the uppercase 'Z': https://github.com/zendframework/ZendDeveloperTools/blob/master/src/Module.php#L132 so this PR is actually changing the invocation to the correct way of calling it. ZF2 will continue to work with it written with either a lower or upper case Z.

@gianarb
Copy link
Contributor

gianarb commented Aug 25, 2016

Thanks @exptom and thanks @MatthiasKuehneEllerhold for this PR

@gianarb gianarb merged commit 1e147bb into doctrine:master Aug 25, 2016
@MatthiasKuehneEllerhold
Copy link
Contributor Author

You're welcome and thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants