metadatagrapher - fix diagram inconcistency #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
gianarb
pushed a commit
that referenced
this pull request
Aug 30, 2015
metadatagrapher - fix diagram inconcistency
|
This sort of change requires tests. |
|
No problem, I understand. |
|
@Ocramius do I revert it? |
|
This is fine as-is: no revert needed, as @Nono1971 is writing the tests separately |
Perfect-Web
added a commit
to Perfect-Web/DoctrineORMModule
that referenced
this pull request
Oct 22, 2015
0.9.2 * [doctrine#423](doctrine#423) Docs about cache updated * [doctrine#428](doctrine#428) metadatagrapher - fix diagram inconcistency * [doctrine#429](doctrine#429) Added naming strategy doc * [doctrine#434](doctrine#434) bump orm to 2.5 dependency * [doctrine#435](doctrine#435) Feature/metadatagrapher fix * [doctrine#437](doctrine#437) Doctrine comment types
Perfect-Web
added a commit
to Perfect-Web/DoctrineORMModule
that referenced
this pull request
Oct 23, 2015
0.9.2 * [doctrine#423](doctrine#423) Docs about cache updated * [doctrine#428](doctrine#428) metadatagrapher - fix diagram inconcistency * [doctrine#429](doctrine#429) Added naming strategy doc * [doctrine#434](doctrine#434) bump orm to 2.5 dependency * [doctrine#435](doctrine#435) Feature/metadatagrapher fix * [doctrine#437](doctrine#437) Doctrine comment types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There was a little inconcistency in the yUML class diagram : when an entity had several entities refering to it with ManyToOne and with the same reference name => if these relations were both bidirectional and moodirectional, the link was not correct, refering on the monodirectional side, the relation of the other entity...
more easy for me to explain with images :
