Added configuration option for RepositoryFactory #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidwindell needs a dependency bump |
|
@Ocramius what's the plans with locking on 2.4? |
|
@davidwindell I'm perfectly fine with locking onto 2.4, so feel free to alter the |
|
@Ocramius Should I lock on >=2.4,<2.5-dev or 2.4.* or..? |
|
I suggest |
|
Great, that's done, tests added, plus I've removed the ALPHA on fixtures as should no longer be needed. |
|
Aaaaaaaaaaaaaaaaand it's merged :) |
Ocramius
added a commit
that referenced
this pull request
Oct 3, 2013
Added configuration option for RepositoryFactory
oprokidnev
pushed a commit
to oprokidnev/DoctrineORMModule
that referenced
this pull request
Apr 19, 2016
Allow to fetch storage from SL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the use of a custom repository factory pulled from the SM (the option is available in ORM since 2.4).
If this is good for merge I'll pop the tests in.