Updated for AnnotationBuilder. #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiffyjr
commented
Jun 5, 2013
spiffyjr
commented
- Made it possible to use the relative path to the targetEntity by hooking into the class metadata.
- Options are merged instead of overridden so you can do things like @Form\Options({"property":"name"}) to set options for the EntityObject's.
- Added relevent tests.
added 5 commits
June 5, 2013 04:11
* Made it possible to use the relative path to the targetEntity by hooking into the class metadata. * Options are merged instead of overridden so you can do things like @Form\Options({"property":"name"}) to set options for the EntityObject's. * Added relevent tests.
|
@Ocramius This should be ready for merge once the tests are passing (coding standards). |
|
Don't merge yet - noticed this doesn't work with non-annotation mappings (xml/yaml). Going to see if I can work around that. |
|
Test pass - status set to READY. |
| */ | ||
| public function setAnnotationManager(AnnotationManager $annotationManager) | ||
| public function getObjectManager() |
| break; | ||
| /** @var \Doctrine\ORM\Mapping\ClassMetadataInfo $metadata */ | ||
| $metadata = $event->getParam('metadata'); | ||
| if ($metadata && $metadata->isAssociationInverseSide($event->getParam('name'))) { |
There was a problem hiding this comment.
directly return the result of this conditional instead of using an if
| $inputSpec = $event->getParam('inputSpec'); | ||
| $elementSpec = $event->getParam('elementSpec'); | ||
|
|
||
| if ($metadata['type'] & ClassMetadataInfo::TO_MANY) { |
There was a problem hiding this comment.
Same as above - these checks can be done via $classMetadata->isCollectionValuedAssociation($field)
ghost
assigned
Ocramius
added a commit
that referenced
this pull request
Jun 11, 2013
[READY] Updated for AnnotationBuilder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.