Add 'entity_listener_resolver' config key #199
Conversation
| )); | ||
| } | ||
|
|
||
| $config->setEntityListenerResolver($serviceLocator->get($entityListenerResolver)); |
There was a problem hiding this comment.
This method is only available in master right now. You should probably throw an exception if method_exists returns false, or this PR has to wait lock onto 2.4 (which may be possible in 3~4 weeks)
There was a problem hiding this comment.
We can wait for 2.4 (:
|
Needs docs :) |
|
Travis fail fixed by zendframework/zendframework#4216 |
|
@danizord can you rebase this one? |
|
@Ocramius done. |
ghost
assigned
|
@danizord ok, a couple more things:
|
| @@ -75,6 +75,21 @@ public function createService(ServiceLocatorInterface $serviceLocator) | |||
| } | |||
| } | |||
|
|
|||
| if ($entityListenerResolver = $options->getEntityListenerResolver()) { | |||
| if (is_string($entityListenerResolver)) { | |||
| if (!$serviceLocator->has($entityListenerResolver)) { | |||
There was a problem hiding this comment.
Should probably just directly call get and let the exception bubble up
|
Any news about this? :) |
|
I'll finish it next weekend. |
|
News? :D |
|
@danizord PR looks nice, I could use this as well. Are you able to finish this? |
|
Sorry for delay guys (I completely forgot this PR), I'm finishing now. |
|
@danizord Thanks for your efforts. We are all busy men, and forget to finish tasks from time to time ;-) |
|
Ping @Ocramius - done ;) |
| ) { | ||
| $this->entityListenerResolver = $entityListenerResolver; | ||
|
|
||
| return $this; |
There was a problem hiding this comment.
The entire class has fluent interface, It should not be homogeneous?
To ensure that the is_string call is executed last
…resolver Add 'entity_listener_resolver' config key
This introduces the possibility to use a custom implementation of
Doctrine\ORM\Mapping\EntityListenerResolverby setting
entity_listener_resolverconfig key.