Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form element annotation builder: ToMany and ToOne support #193

Merged
merged 3 commits into from
May 20, 2013

Conversation

Ocramius
Copy link
Member

Adds *ToMany and *ToOne support to the DoctrineORMModule\Form\Annotation\ElementAnnotationsListener

Cleaned up version of #191

@spiffyjr
Copy link

Oh, you did the CS fixes for me, eh?

<3

@Ocramius
Copy link
Member Author

@spiffyjr yes, but I'm delaying it as you can see from the modified UPGRADE.md. (It was easier to pull and fix than to comment on each CS problem :) )

@spiffyjr
Copy link

Works for me, thanks.

@internalsystemerror
Copy link
Contributor

Is the ElementAnnotationsListener::attach() method not missing:

$this->listeners[] = $events->attach('configureElement', array($this, 'handleToOneAnnotation'));

Also, would it be possible not to override the $elementSpec['spec']['options'] array and instead to extend it? That way, its possible to set the property in the annotations instead of forcing the use of __toString().

Ocramius added a commit that referenced this pull request May 20, 2013
Form element annotation builder: `ToMany` and `ToOne` support
@Ocramius Ocramius merged commit aa268c1 into master May 20, 2013
@Ocramius Ocramius deleted the pr/element-annotations-cleanup branch May 20, 2013 19:36
@BrunoSpy
Copy link

Is there some doc somewhere which describe how to use this new feature ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants