Removing travis allow failure for php7.4 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ishyevandro thanks for the contribution. Could you please rebase the PR and point it to the 3.6 branch? Thanks! |
|
Hi @alcaeus, i don't get it. Can you explain with more details? (New in the world of contribution) |
|
As I was writing up the guideline I noticed that we don't test 3.6 against PHP 7.4 at all. So there are no changes necessary from your end here. Instead, I suggest we take care of this in a separate pull request. If you're up for it, go ahead and give it a shot! |
|
@alcaeus, there's one fail in 7.3 and deprecation problems in all versions. https://travis-ci.org/doctrine/DoctrineMongoDBBundle/builds/591927014 |
|
#586 will fix these deprecations, we'll take another look afterwards 👍 |
alcaeus
added
CI
Hacktoberfest
alcaeus
approved these changes
Oct 2, 2019
|
Thanks @ishyevandro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#587