Deprecate default_repository_class option #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
deprecate-repository-class-option
branch
from
0960ec9 to
8046f9f
Compare
jwage
approved these changes
Sep 2, 2018
malarzm
reviewed
Sep 2, 2018
UPGRADE-3.5.md
Outdated
| ======================= | ||
|
|
||
| * The `default_repository_class` configuration was deprecated and will be | ||
| removed in 4.0. Use the `default_documen_repository_class` option instead. |
There was a problem hiding this comment.
Missing "t" by the end of "documen" :)
malarzm
reviewed
Sep 2, 2018
| @@ -173,7 +173,7 @@ protected function loadDocumentManager(array $documentManager, $defaultDM, $defa | |||
| 'setDefaultCommitOptions' => '%doctrine_mongodb.odm.default_commit_options%', | |||
| 'setRetryConnect' => $documentManager['retry_connect'], | |||
| 'setRetryQuery' => $documentManager['retry_query'], | |||
| 'setDefaultRepositoryClassName' => $documentManager['default_repository_class'], | |||
| 'setDefaultRepositoryClassName' => $documentManager['default_document_repository_class'] ?: $documentManager['default_repository_class'], | |||
There was a problem hiding this comment.
Not sure if it's worth the hassle, but doctrine/mongodb-odm#1840 will provide a forward compatibility thus with an if check bundle could not call deprecated method.
There was a problem hiding this comment.
Good point - I updated the code to call the new method if it exists. Will drop that distinction in 4.0.
malarzm
approved these changes
Sep 2, 2018
alcaeus
force-pushed
the
deprecate-repository-class-option
branch
from
8046f9f to
09c33e8
Compare
malarzm
reviewed
Sep 2, 2018
|
Looks like deprecating config was only introduced in symfony/config 3.4 - I'm considering dropping support for Symfony versions older than 3.4 - opinions? Edit: dang, you're fast. Will drop it. |
|
Dropped it is 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the
default_repository_classoption in 3.5 for removal in 4.0. The new option is calleddefault_document_repository_class.