Remove TLS_RSA ciphers from the default accepted cipher suite #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggers scanning warnings Signed-off-by: Nassim 'Nass' Eddequiouaq <[email protected]>
|
These have no forward secrecy either. However, it is worth testing with our supported browser set with this disabled to check that they are not required for compatibility. |
|
Some context: it's ROBOT that trips some scanners. The ROBOT vulnerability site, linked below, notes that Cloudflare says 1% of connections use TLS_RSA ciphers. |
Those stats can be very different in specific scopes (e.g. "enterprise" environments may be restricted to older browsers, "design studios" will be using bleeding edge browsers), so we should be sure to look at target audiences we have. |
justincormack
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It triggers warnings on various TLS/network scanners and is not considered as best security practice.
cc @thaJeztah @endophage @justincormack
Signed-off-by: Nassim 'Nass' Eddequiouaq [email protected]