integration: test_create_volume_invalid_driver allow either 400 or 404 #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
fix_test_create_volume_invalid_driver
branch
from
cd75d97 to
246207f
Compare
p1-0tr
reviewed
Jan 14, 2025
tests/integration/api_volume_test.py
Outdated
| self.client.create_volume('perfectcherryblossom', driver_name) | ||
| assert ( |
There was a problem hiding this comment.
Shouldn't this assert be in the with block?
There was a problem hiding this comment.
oh! quite likely. It's been a while since I wrote this patch, so don't recall what I did here 😂
Let me fix!
There was a problem hiding this comment.
At least, I think that's what you meant, right? 🙈
(don't trust me with your Python code)
There was a problem hiding this comment.
Yup, I am pretty sure it would work either way. The with: block should clean up anything it created (the 'as' variables) when its scope ends, but IIRC the variable names stay around (they only get removed when a proper scope (function) ends). I've not done much python in 7 (or more 🤔) years so I may be misremembering the details.
The API currently returns a 404 error when trying to create a volume with an invalid (non-existing) driver. We are considering changing this status code to be a 400 (invalid parameter), as even though the _reason_ of the error may be that the plugin / driver is not found, the _cause_ of the error is that the user provided a plugin / driver that's invalid for the engine they're connected to. This patch updates the test to pass for either case. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix_test_create_volume_invalid_driver
branch
from
246207f to
fad84c3
Compare
thompson-shaun
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API currently returns a 404 error when trying to create a volume with an invalid (non-existing) driver. We are considering changing this status code to be a 400 (invalid parameter), as even though the reason of the error may be that the plugin / driver is not found, the cause of the error is that the user provided a plugin / driver that's invalid for the engine they're connected to.
This patch updates the test to pass for either case.