-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cacheFrom to build options #1383
Conversation
Signed-off-by: Thomas Schaaf <[email protected]>
Is there a problem with my addtion? |
@shin- ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A nit: the cachefrom
option also needs to be added to the ImageCollection
docstring.
(@shin- perhaps we should add a comment to duped docstrings like this to remind contributors to copy changes between them.)
@thomaschaaf can you update the ImageCollection docstring? |
@thomaschaaf To save you the search, this is where it should be added: docker-py/docker/models/images.py Lines 111 to 142 in bb66525
|
@thomaschaaf @MichaelPereira I've got a fork of this at #1417 with that change. |
Closing: #1417 |
This adds the cache-from build option (moby/moby#26839) and fixes #1382.