Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Channel double close panic on Ctrl-C during up #11710

Closed
milas opened this issue Apr 10, 2024 · 0 comments · Fixed by #11719
Closed

[BUG] Channel double close panic on Ctrl-C during up #11710

milas opened this issue Apr 10, 2024 · 0 comments · Fixed by #11719

Comments

@milas
Copy link
Contributor

milas commented Apr 10, 2024

Description

panic: close of closed channel

goroutine 361 [running]:
github.com/docker/compose/v2/pkg/compose.(*composeService).Up.func2.1.1()
	github.com/docker/compose/v2/pkg/compose/up.go:87 +0xa4
github.com/hashicorp/go-multierror.(*Group).Go.func1()
	github.com/hashicorp/[email protected]/group.go:23 +0x60
created by github.com/hashicorp/go-multierror.(*Group).Go in goroutine 292
	github.com/hashicorp/[email protected]/group.go:20 +0x84

Steps To Reproduce

  1. docker compose up foo --build
  2. Hit Ctrl-C

(Does not happen consistently)

Compose Version

Docker Compose version v2.26.1-desktop.1

Docker Environment

Client:
 Version:    26.0.0
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.13.1-desktop.1
    Path:     /Users/milas/.pinata/downloads/docker-plugins/v0.13.1-desktop.1/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.26.1-desktop.1
    Path:     /Users/milas/.docker/cli-plugins/docker-compose
  debug: Get a shell into any image or container. (Docker Inc.)
    Version:  0.0.28
    Path:     /Users/milas/.docker/cli-plugins/docker-debug
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.2
    Path:     /Users/milas/.docker/cli-plugins/docker-dev
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.23
    Path:     /Users/milas/.docker/cli-plugins/docker-extension
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.4
    Path:     /Users/milas/.docker/cli-plugins/docker-feedback
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.1.0
    Path:     /Users/milas/.docker/cli-plugins/docker-init
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     /Users/milas/.docker/cli-plugins/docker-sbom
  scout: Docker Scout (Docker Inc.)
    Version:  v1.6.4
    Path:     /Users/milas/.docker/cli-plugins/docker-scout

Server:
 Containers: 4
  Running: 1
  Paused: 0
  Stopped: 3
 Images: 5
 Server Version: 26.0.0
 Storage Driver: overlayfs
  driver-type: io.containerd.snapshotter.v1
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
  cgroupns
 Kernel Version: 6.6.25-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 10
 Total Memory: 7.657GiB
 Name: docker-desktop
 ID: b9c84653-c013-4d10-a599-f3a4e722188f
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Labels:
  com.docker.desktop.address=unix:///Users/milas/Library/Containers/com.docker.docker/Data/docker-cli.sock
 Experimental: true
 Insecure Registries:
  hubproxy.docker.internal:5555
  127.0.0.0/8
 Live Restore Enabled: false

Anything else?

No response

ndeloof pushed a commit that referenced this issue Apr 20, 2024
…on compose up (#11719)

Ensure done channel is closed only once

Signed-off-by: Jaime Soriano Pastor <[email protected]>
temenuzhka-thede pushed a commit to temenuzhka-thede/compose that referenced this issue Sep 17, 2024
…trl-C on compose up (docker#11719)

Ensure done channel is closed only once

Signed-off-by: Jaime Soriano Pastor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant