vendor: github.com/spf13/cobra v1.9.1 #5829
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5829 +/- ##
==========================================
+ Coverage 58.79% 59.18% +0.38%
==========================================
Files 349 352 +3
Lines 29536 29547 +11
==========================================
+ Hits 17367 17486 +119
+ Misses 11186 11080 -106
+ Partials 983 981 -2 |
full diff: spf13/cobra@v1.8.1...v1.9.1 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
bump_cobra
branch
from
5e8876c to
047767a
Compare
thaJeztah
changed the title
Cobra now defines a CompletionFunc for the same, so we can alias it to that, and stop using our own definition. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
FWIW; keeping this in draft, because docker/cli is a dependency of buildx, and I don't want to force it to update to latest cobra this late in the release; we can consider it for a minor release or next major release though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor: github.com/spf13/cobra v1.9.1
full diff: spf13/cobra@v1.8.1...v1.9.1
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)