fixes #1441 set default schema to tcp for docker host #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifubang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1443 +/- ##
==========================================
- Coverage 54.2% 54.19% -0.01%
==========================================
Files 289 289
Lines 19378 19377 -1
==========================================
- Hits 10503 10502 -1
Misses 8199 8199
Partials 676 676 |
Signed-off-by: Lifubang <[email protected]>
lifubang
force-pushed
the
defaulttcpschema
branch
from
05f90d1 to
2431dd1
Compare
|
I have update a more reasonable schema parse method. |
Signed-off-by: Lifubang <[email protected]>
@silvin-lubecki Thank you for your review. |
AkihiroSuda
approved these changes
Oct 16, 2018
|
Shall we need to merge to 18.09? Otherwise the version 18.09 will become the only version which doesn't support default host schema. |
|
@lifubang yes, I had this one on my list to backport to 18.09 |
|
Can you open a pr to the release branch? |
|
@cpuguy83 almost done 😅 |
|
haha, posting at the same time. |
|
backport is up #1454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lifubang [email protected]
- What I did
Please see #1441
There is a traditional command "docker -H :2375 ps" in docker cli, but in master, it can't work now.
Is this feature removed in plan or just an error?
- How I did it
I think this may be a bug after merge #1014
add case ssh to dopts.ParseHost, together with all other schema.
- How to verify it
see #1441
fixes #1441
fixes moby/moby#38118
- Description for the changelog
set default schema to tcp for docker host param when there is no schema
- A picture of a cute animal (not mandatory but encouraged)
